Hi,
On 12/11/15 16:40, Roger Pau Monné wrote:
>> [1] http://lists.xen.org/archives/html/xen-devel/2015-08/msg02200.html
>>
>> Signed-off-by: Julien Grall <[email protected]>
>
> LGTM, only a couple of typos and a simplification:
>
> Signed-off-by: Roger Pau Monné <[email protected]>
Do you mean Acked-by? ;)
>> +
>> + /* The I/O request may be split in two */
>> + if (unlikely(s->associated_id != NO_ASSOCIATED_ID)) {
>> + struct blk_shadow *s2 = &info->shadow[s->associated_id];
>> +
>> + /* Keep the status of the current response in shadow */
>> + s->status = (bret->status == BLKIF_RSP_OKAY) ?
>> + REQ_DONE : REQ_FAIL;
>> +
>> + /* Wait the second response if not yet here */
>> + if (s2->status == REQ_WAITING)
>> + return 0;
>> +
>> + /*
>> + * The status of the current response will be used in
>> + * order to know if the request has failed.
>> + * Update the current response status only if has not
>> + * failed.
>> + */
>> + if (bret->status == BLKIF_RSP_OKAY && s2->status == REQ_FAIL)
>
> This could be simplified by only checking if s2->status == REQ_FAIL.
I didn't do it because bret->status may be different than
BLKIF_RSP_ERROR (for instance BLKIF_RSP_EOPNOTSUPP).
Regards,
--
Julien Grall
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
