On Thu, Nov 12, 2015 at 12:32:13PM +0100, Vitaly Kuznetsov wrote:
> @@ -85,10 +86,10 @@ static ssize_t hvt_op_write(struct file *file, const char
> __user *buf,
> return PTR_ERR(inmsg);
>
> if (hvt->on_msg(inmsg, count))
> - return -EFAULT;
> + ret = -EFAULT;
You fix this leak and then re-introduce it again directly in patch 3/4.
Also it might be nice to preserve the error code.
ret = hvt->on_msg(inmsg, count);
kfree(inmsg);
return ret ? ret : count;
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
