On 11/20/2015 10:19 AM, Viresh Kumar wrote: > On 20-11-15, 10:10, Prarit Bhargava wrote: >>>> limits->max_policy_pct = clamp_t(int, limits->max_policy_pct, 0 , 100); >>> >>> And put this after the later one ? >>> >>>> + limits->max_policy_pct = DIV_ROUND_UP(policy->max * 100, >>>> + policy->cpuinfo.max_freq); >>>> >>>> /* Normalize user input to [min_policy_pct, max_policy_pct] */ >>>> limits->min_perf_pct = max(limits->min_policy_pct, >>> >>> Sure you tested it ? :) >> >> Oops -- and yeah, tested. It works because I rewrite the value of >> max_policy_pct :). I'll repost shortly. > > But we aren't doing below anymore, doesn't this change the > calculations at all? > > limits->max_policy_pct = clamp_t(int, limits->max_policy_pct, 0 , 100);
The clamp only confines the max_policy between 0 and 100. AFAIK it doesn't make any change tothe value of limits->max_policy_pct unless it was outside of that range. P. > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/