On Thu, Nov 19, 2015 at 4:31 AM, Jia He <[email protected]> wrote: > This patch moves the mask macro to bitops.h and then the new introduced > api in find_bit.c can use it.
Why API can't use GENMASK() instead? > > Signed-off-by: Jia He <[email protected]> > --- > include/linux/bitmap.h | 3 --- > include/linux/bitops.h | 4 ++++ > 2 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/include/linux/bitmap.h b/include/linux/bitmap.h > index 9653fdb..15524f6 100644 > --- a/include/linux/bitmap.h > +++ b/include/linux/bitmap.h > @@ -172,9 +172,6 @@ extern unsigned int bitmap_ord_to_pos(const unsigned long > *bitmap, unsigned int > extern int bitmap_print_to_pagebuf(bool list, char *buf, > const unsigned long *maskp, int nmaskbits); > > -#define BITMAP_FIRST_WORD_MASK(start) (~0UL << ((start) & (BITS_PER_LONG - > 1))) > -#define BITMAP_LAST_WORD_MASK(nbits) (~0UL >> (-(nbits) & (BITS_PER_LONG - > 1))) > - > #define small_const_nbits(nbits) \ > (__builtin_constant_p(nbits) && (nbits) <= BITS_PER_LONG) > > diff --git a/include/linux/bitops.h b/include/linux/bitops.h > index 2b8ed12..b881028 100644 > --- a/include/linux/bitops.h > +++ b/include/linux/bitops.h > @@ -24,6 +24,10 @@ > #define GENMASK_ULL(h, l) \ > (((~0ULL) << (l)) & (~0ULL >> (BITS_PER_LONG_LONG - 1 - (h)))) > > +/* For bitmap ops*/ > +#define BITMAP_FIRST_WORD_MASK(start) (~0UL << ((start) & (BITS_PER_LONG - > 1))) > +#define BITMAP_LAST_WORD_MASK(nbits) (~0UL >> (-(nbits) & (BITS_PER_LONG - > 1))) > + > extern unsigned int __sw_hweight8(unsigned int w); > extern unsigned int __sw_hweight16(unsigned int w); > extern unsigned int __sw_hweight32(unsigned int w); > -- > 2.5.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to [email protected] > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
