On 04/11/2015 at 07:36:37 -0800, Joshua Clayton wrote : > + ret = pcf2123_rtc_read_time(dev, &tm); > + if (ret < 0) > + return false; > + > + if (rtc_valid_tm(&tm) < 0) { > + dev_err(dev, "retrieved date/time is not valid.\n"); > + return false; > + } > +
I would remove that test as basically, the date/time will only be valid when OSC_HAS_STOPPED is not set. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/