On Sat, 2006-12-09 at 13:14 +0000, Alan wrote: > On Sat, 09 Dec 2006 03:12:11 -0500 > Ben Collins <[EMAIL PROTECTED]> wrote: > > My controller is in legacy mode, however, it never gets to here because > > of this call, just before this block of code: > > > > rc = pci_request_regions(pdev, DRV_NAME); > > if (rc) { > > disable_dev_on_err = 0; > > goto err_out; > > } > > Then you don't have the fix applied that was posted. That code is not > present in the form you pasted in the fixed version of the libata code. > It is within an if (!legacy_mode)
I didn't see that patch until you mentioned it. Even still, there seems to be one thing missing. I suspect you still want to take the bmdma resource since both native and legacy use it. With the patch you mentioned, that resource wont be requested in legacy mode. Also, I did my patch as detailed as it is because of this line: /* TODO: What if one channel is in native mode ... */ If that's never going to be the case then the comment should go. If it is possible, then my patch makes this work. The way things are now, it will ignore a native mode port if it is sitting on the same controller as a legacy mode one. Want to re-evaluate the patch based on this info? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/