On Fri, Nov 27, 2015 at 08:39:32AM +0100, Ingo Molnar wrote:
>
> * Seth Jennings <sjenni...@variantweb.net> wrote:
>
> > v2:
> > remove local bz variable (Ingo) and debug message since, if
> > the 2GB message doesn't print, there is only one possible
> > block size.
>
> I'd not remove the info message, it would print the memory block size
> regardless
> of memory size. Yes, one could decode the 'no message' case as 'the kernel
> used
> the default value' - but that's very version dependent and obscure in any
> case.
> Please keep the debug message in both code paths, like the original code had
> it.
>
> But, on a second thought, I'd definitely harmonize the messages, instead of:
>
> > pr_info("Using 2GB memory block size for large-memory
> > system\n");
> > printk(KERN_DEBUG "memory block size : %ldMB\n", bz >> 20);
>
> I'd print:
>
> > pr_info("x86/mm: Memory block size: 2GB, large-memory
> > system\n");
> > pr_info("x86/mm: Memory block size: %ldMB\n", bz >> 20);
>
> Also note how I changed both printouts to pr_info(), so that we have the
> memory
> block size information printed unconditionally.
>
> (And btw., doing this printout means that we should keep the 'bz' local
> variable.)
Just sent out v3.
Thanks,
Seth
>
> Thanks,
>
> Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
