On 11/30, Masahiro Yamada wrote: > Hi Stephen, > > > > >> > >> Of course we can, although we have to mention "clock-indices" twice. > >> > >> A good thing for of_get_property() is that we can get both the value > >> and the length > >> at the same time. > >> > > > > Ok. Well if we don't want to count them again, perhaps a goto > > jump over an unconditional return NULL would be better? > > > > of_property_for_each_u32(clkspec.np, "clock-indices", prop, vp, pv) > > { > > if (index == pv) { > > index = count; > > goto found; > > } > > count++; > > } > > > > return NULL; > > found: > > > > Or since the macro for of_property_for_each_u32() tests the vp > > poitner for NULL, we can check that pointer too... > > > > of_property_for_each_u32(clkspec.np, "clock-indices", prop, vp, pv) > > { > > if (index == pv) { > > index = count; > > break; > > } > > count++; > > } > > > > /* We didn't find anything */ > > if (!vp) > > return NULL; > > > > I guess I prefer the latter approach here. > > > > No. > > Neither of your two suggestions works because they are false positive. >
So if (!vp && count) then? -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/