Hi Brain,
于 2015年12月03日 08:49, Brian Norris 写道:
Hi Caesar,
On Thu, Dec 03, 2015 at 08:42:38AM +0800, Caesar Wang wrote:
? 2015?12?03? 02:38, Brian Norris ??:
[.....]
if (thermal->tshut_temp > INT_MAX) {
CID 1341498: Integer handling issues (CONSTANT_EXPRESSION_RESULT)
"thermal->tshut_temp > 2147483647 /* (int)(~0U >> 1) */" is always false
regardless of the values of its operands. This occurs as the logical operand of if.
I don't think this condition is even useful any more, so maybe we should
just kill the 'if' block.
See the patch to fix
it.----->(https://patchwork.kernel.org/patch/7720601/)
<https://patchwork.kernel.org/patch/7720601/>
- if (thermal->tshut_temp > INT_MAX) {
+ if (!(thermal->tshut_temp < INT_MAX)) {
Huh? That still doesn't make much sense. The condition is still
impossible, since thermal->tshut_temp is an int. You've just made it
slightly harder for static analyzers to notice the impossibility.
Okay, that's possible remove this condition as you said.
- if (thermal->tshut_temp > INT_MAX) {
- dev_err(dev, "Invalid tshut temperature specified: %d\n",
- thermal->tshut_temp);
- return -ERANGE;
- }
Thanks!
This patch is merged into kernel 4.4-rc3.
No it isn't, and I'm glad. The patch is silly.
Brian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
