Hello Martin, On Thu, Dec 03, 2015 at 09:51:44AM +0100, [email protected] wrote: > From: Martin Wilck <[email protected]> > > Since b8b2c7d845d5, platform_drv_probe() is called for all platform > devices. If drv->probe is NULL, and dev_pm_domain_attach() fails, > platform_drv_probe() will return the error code from dev_pm_domain_attach(). > > This causes real_probe() to enter the "probe_failed" path and set > dev->driver to NULL. Before b8b2c7d845d5, real_probe() would assume > success if both dev->bus->probe and drv->probe were missing. As a result, > a device and driver could be "bound" together just by matching their names; > this doesn't work any more after b8b2c7d845d5. > > This change broke the assumptions of certain drivers; for example, the TPM > code has long assumed that platform driver and device with matching name > could be bound in this way. That assumption may cause such drivers to > fail with Oops during initialization after applying this change. Failure > in suspend/resume tests under qemu has also been reported. > > This patch restores the previous (4.3.0 and earlier) behavior of > platform_drv_probe() in the case when the associated platform driver has > no "probe" function. > > Fixes: b8b2c7d845d5 ("base/platform: assert that dev_pm_domain callbacks are > called unconditionally") > Signed-off-by: Martin Wilck <[email protected]>
Acked-by: Uwe Kleine-König <[email protected]> Thanks Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
