On Tue, Dec 12, 2006 at 01:55:24PM -0600, Linas Vepstas wrote: > > Greg, Andrew, > > This patch fixes an annoying numbering mistake. > Please apply this (and the next patch). > > --linas > > Subject: [PATCH 1/2]: Renumber PCI error enums to start at zero > > Renumber the PCI error enums to start at zero for "normal/online". > This allows un-initialized pci channel state (which defaults to zero) > to be interpreted as "normal". Add very simple routine to check > state, just in case this ever has to be fiddled with again.
No, as you have a specific type for this state, never test it against "zero". That just defeats the whole issue of having a special type for this state. So you should not have to change the values of the enumerated type for the code to work properly. In fact, I would argue that we should not change it for this very reason :) So, care to respin these without the enum changes to provide the new function and use it? thanks, greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
