Request_irq() should be _after_ h/w programming, otherwise an
interrupt could be triggered and in-progress before the h/w has been
setup.
Reported-by: Peter Hurley <pe...@hurleysoftware.com>
Signed-off-by: Soren Brinkmann <soren.brinkm...@xilinx.com>
---
v4:
- this patch has been added. Thanks to Peter for pointing it out and providing
commit message
---
drivers/tty/serial/xilinx_uartps.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/tty/serial/xilinx_uartps.c
b/drivers/tty/serial/xilinx_uartps.c
index 6ffd3bbe3e18..1e9053656610 100644
--- a/drivers/tty/serial/xilinx_uartps.c
+++ b/drivers/tty/serial/xilinx_uartps.c
@@ -759,12 +759,7 @@ static void cdns_uart_set_termios(struct uart_port *port,
static int cdns_uart_startup(struct uart_port *port)
{
unsigned long flags;
- unsigned int retval = 0, status = 0;
-
- retval = request_irq(port->irq, cdns_uart_isr, 0, CDNS_UART_NAME,
- (void *)port);
- if (retval)
- return retval;
+ unsigned int status = 0;
spin_lock_irqsave(&port->lock, flags);
@@ -818,7 +813,7 @@ static int cdns_uart_startup(struct uart_port *port)
spin_unlock_irqrestore(&port->lock, flags);
- return retval;
+ return request_irq(port->irq, cdns_uart_isr, 0, CDNS_UART_NAME, port);
}
/**
--
2.6.3.3.g9bb996a
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
