On 07/12/15 23:09, Arnaldo Carvalho de Melo wrote: > Em Thu, Dec 03, 2015 at 10:06:39AM +0100, Jiri Olsa escreveu: >> hi, >> while testing ftrace:function event I noticed we create >> stat counters as enabled (except for enable_on_exec couters). >> >> This way we count also filter setup and other config code >> which might be crucial for some events. >> >> Posponing the events enable once everything is ready. >> >> The last patch is RFC as I wasn't sure there's some hidden >> catch about perf_evlist__(enable|disable)_event functions >> I missed.. Adrian? > > They look the same, Adrian? > > Applied the first 6, will give some more time to Adrian to chime in.
Looks like there might already be a problem using evsel->threads instead of evlist->threads with the logic relating to evsel->system_wide getting lost - but that happened already in "perf evlist: Factor perf_evlist__(enable|disable) functions". Probably the threads should not be propagated in that case, but it needs more investigation. I will try to look at it today. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
