The test suite currently doesn't cover many corner cases when hex_dump_to_buffer() runs into overflow. Refactor and amend test suite to cover most of the cases.
Andrew, please, update entire series in your pool. Changelog v2: - address Rasmus' comments - add tags Andy Shevchenko (9): test_hexdump: rename to test_hexdump test_hexdump: introduce test_hexdump_prepare_test() helper test_hexdump: define FILL_CHAR constant test_hexdump: go through all possible lengths of buffer test_hexdump: replace magic numbers by their meaning test_hexdump: switch to memcmp() test_hexdump: check all bytes in real buffer test_hexdump: test all possible group sizes for overflow test_hexdump: print statistics at the end lib/Makefile | 2 +- lib/{test-hexdump.c => test_hexdump.c} | 146 +++++++++++++++++++++++---------- 2 files changed, 103 insertions(+), 45 deletions(-) rename lib/{test-hexdump.c => test_hexdump.c} (52%) -- 2.6.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/