On Mon, Dec 14, 2015 at 04:55:28PM +0100, Jiri Olsa wrote: > On Mon, Dec 14, 2015 at 09:38:15AM -0600, Josh Poimboeuf wrote: > > On Mon, Dec 14, 2015 at 04:29:39PM +0100, Jiri Olsa wrote: > > > On Mon, Dec 14, 2015 at 08:29:07AM -0600, Josh Poimboeuf wrote: > > > > Signed-off-by: Josh Poimboeuf <jpoim...@redhat.com> > > > > > > you might want to work on your changelogs > > > a little.. aaand actually include some ;-) > > > > Well, I thought the subject said it all :-) > > well, you could be more specific, like: > - how was it broken before > - what did you do to fix it > - how you added a test case to ensure this will never happen again ;-) > > it makes the life of reviewer a bit easier, anyway: > > Acked-by: Jiri Olsa <jo...@kernel.org>
Thanks. I'll try to be more verbose in future changelogs. -- Josh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
