On 2015년 12월 14일 19:06, Andrzej Hajda wrote:
> The function can return negative values, so its result should
> be assigned to signed variable.
> 
> The problem has been detected using proposed semantic patch
> scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1].
> 
> [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107
> 
> Signed-off-by: Andrzej Hajda <[email protected]>
> ---
>  drivers/extcon/extcon-max14577.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/extcon/extcon-max14577.c 
> b/drivers/extcon/extcon-max14577.c
> index 601dbd9..b30ab97 100644
> --- a/drivers/extcon/extcon-max14577.c
> +++ b/drivers/extcon/extcon-max14577.c
> @@ -692,7 +692,7 @@ static int max14577_muic_probe(struct platform_device 
> *pdev)
>       /* Support irq domain for max14577 MUIC device */
>       for (i = 0; i < info->muic_irqs_num; i++) {
>               struct max14577_muic_irq *muic_irq = &info->muic_irqs[i];
> -             unsigned int virq = 0;
> +             int virq = 0;
>  
>               virq = regmap_irq_get_virq(max14577->irq_data, muic_irq->irq);
>               if (virq <= 0)
> 

Applied it.

Thanks,
Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to