On Wed, Dec 16, 2015 at 07:23:22PM +0800, Daniel Kurtz wrote: > On Mon, Nov 30, 2015 at 7:42 PM, Sascha Hauer <[email protected]> wrote: > > This adds the device tree binding documentation for the mediatek thermal > > controller found on Mediatek MT8173 and other SoCs. > > > > Signed-off-by: Sascha Hauer <[email protected]> > > Reviewed-by: Daniel Kurtz <[email protected]> > > Acked-by: Rob Herring <[email protected]> > > --- > > .../bindings/thermal/mediatek-thermal.txt | 43 > > ++++++++++++++++++++++ > > 1 file changed, 43 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/thermal/mediatek-thermal.txt > > > > diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt > > b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt > > new file mode 100644 > > index 0000000..81f9a51 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt > > @@ -0,0 +1,43 @@ > > +* Mediatek Thermal > > + > > +This describes the device tree binding for the Mediatek thermal controller > > +which measures the on-SoC temperatures. This device does not have its own > > ADC, > > +instead it directly controls the AUXADC via AHB bus accesses. For this > > reason > > +this device needs phandles to the AUXADC. Also it controls a mux in the > > +apmixedsys register space via AHB bus accesses, so a phandle to the > > APMIXEDSYS > > +is also needed. > > + > > +Required properties: > > +- compatible: "mediatek,mt8173-thermal" > > +- reg: Address range of the thermal controller > > +- interrupts: IRQ for the thermal controller > > +- clocks, clock-names: Clocks needed for the thermal controller. required > > + clocks are: > > + "therm": Main clock needed for register access > > + "auxadc": The AUXADC clock > > +- resets: Reference to the reset controller controlling the thermal > > controller. > > +- mediatek,auxadc: A phandle to the AUXADC which the thermal controller > > uses > > +- mediatek,apmixedsys: A phandle to the APMIXEDSYS controller. > > +- #thermal-sensor-cells : Should be 0. See ./thermal.txt for a description. > > + > > +Optional properties: > > +- nvmem-cells: A phandle to the calibration data provided by a nvmem > > device. If > > + unspecified default values shall be used. > > +- nvmem-cell-names: Should be "calibration-data" > > + > > +Example: > > + > > + thermal: thermal@1100b000 { > > + #thermal-sensor-cells = <1>; > > Tiny nit: this should now be: > > #thermal-sensor-cells = <0>;
This is actually not so tiny'shy. Why does this driver masks out all sensors available? Why don't we expose all of them and use id property to expose and identify each of them? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
