Hi Woodhouse, Norris, Do you have any comments for this patch?
Thanks for your review. Best Regards, Yuan Yao > -----Original Message----- > From: Han Xu [mailto:han...@freescale.com] > Sent: Thursday, November 26, 2015 3:09 AM > To: Yuan Yao-B46683 <yao.y...@freescale.com> > Cc: dw...@infradead.org; computersforpe...@gmail.com; linux- > ker...@vger.kernel.org; linux-...@lists.infradead.org > Subject: Re: [PATCH v2] mtd: spi-nor: fsl-quadspi: add big-endian support On Thu, Nov 26, 2015 at > On Wed, Nov 18, 2015 at 05:13:28PM +0800, Yuan Yao wrote: > > Add R/W functions for big- or little-endian registers: > > The qSPI controller's endian is independent of the CPU core's endian. > > So far, the qSPI have two versions for big-endian and little-endian. > > > > Signed-off-by: Yuan Yao <yao.y...@freescale.com> > > --- > > Changed in v2: > > Rebase to the lastest code. > > --- > > drivers/mtd/spi-nor/fsl-quadspi.c | 157 > > +++++++++++++++++++++++--------------- > > 1 file changed, 97 insertions(+), 60 deletions(-) > > > > diff --git a/drivers/mtd/spi-nor/fsl-quadspi.c > > b/drivers/mtd/spi-nor/fsl-quadspi.c > > index 9e7f657..0ce7768 100644 ... > > @@ -954,6 +990,7 @@ static int fsl_qspi_probe(struct platform_device > *pdev) > > if (IS_ERR(q->iobase)) > > return PTR_ERR(q->iobase); > > > > + q->big_endian = of_property_read_bool(np, "big-endian"); > > I am fine with this patch, but need document the new property with another > patch > > > res = platform_get_resource_byname(pdev, IORESOURCE_MEM, > > "QuadSPI-memory"); > > if (!devm_request_mem_region(dev, res->start, resource_size(res), > @@ ... > > > > Acked-by: Han xu <han...@freescale.com> > -- Best Regards, Yuan Yao -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
