I hit this warning fairly frequently when resuming 4.4-rc5:
ret = usermodehelper_read_trylock();
if (WARN_ON(ret)) {
dev_err(device, "firmware: %s will not be loaded\n",
name);
goto out;
}
It seems like it could be improved in two ways fairly easily:
1. Shouldn't firmware_class try the direct load before trying to get
the usermodehelper lock?
2. Why is the !NOWAIT case doing a trylock? That seems wrong.
--Andy
--
Andy Lutomirski
AMA Capital Management, LLC
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
