On Fri 18-12-15 22:22:19, Ross Zwisler wrote:
> To properly support the new DAX fsync/msync infrastructure filesystems
> need to call dax_pfn_mkwrite() so that DAX can track when user pages are
> dirtied.

The patch looks good to me. You can add:

Reviewed-by: Jan Kara <j...@suse.cz>

                                                                Honza

> 
> Signed-off-by: Ross Zwisler <ross.zwis...@linux.intel.com>
> ---
>  fs/ext4/file.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/ext4/file.c b/fs/ext4/file.c
> index 749b222..8c8965c 100644
> --- a/fs/ext4/file.c
> +++ b/fs/ext4/file.c
> @@ -291,8 +291,8 @@ static int ext4_dax_pfn_mkwrite(struct vm_area_struct 
> *vma,
>  {
>       struct inode *inode = file_inode(vma->vm_file);
>       struct super_block *sb = inode->i_sb;
> -     int ret = VM_FAULT_NOPAGE;
>       loff_t size;
> +     int ret;
>  
>       sb_start_pagefault(sb);
>       file_update_time(vma->vm_file);
> @@ -300,6 +300,8 @@ static int ext4_dax_pfn_mkwrite(struct vm_area_struct 
> *vma,
>       size = (i_size_read(inode) + PAGE_SIZE - 1) >> PAGE_SHIFT;
>       if (vmf->pgoff >= size)
>               ret = VM_FAULT_SIGBUS;
> +     else
> +             ret = dax_pfn_mkwrite(vma, vmf);
>       up_read(&EXT4_I(inode)->i_mmap_sem);
>       sb_end_pagefault(sb);
>  
> -- 
> 2.5.0
> 
> 
-- 
Jan Kara <j...@suse.com>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to