Hi Julia, Am Montag, 21. Dezember 2015, 17:39:47 schrieb Julia Lawall: > for_each_child_of_node performs an of_node_get on each iteration, so a > return from the loop requires an of_node_put. > > A simplified version of the semantic patch that fixes this problem is as > follows (http://coccinelle.lip6.fr): > > // <smpl> > @@ > local idexpression n; > expression e,e1; > @@ > > for_each_child_of_node(e1,n) { > ... > ( > of_node_put(n); > > e = n > > return n; > > + of_node_put(n); > ? return ...; > ) > ... > } > // </smpl> > > Signed-off-by: Julia Lawall <julia.law...@lip6.fr>
thanks for catching this :-) I still remember how we talked about that same issue in the phy driver and the things for_each_child_of_node does when running, so Reviewed-by: Heiko Stuebner <he...@sntech.de> Thanks Heiko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
