> -----Original Message----- > From: Jun Li [mailto:[email protected]] > Sent: Wednesday, December 23, 2015 10:36 AM > To: Felipe Balbi <[email protected]>; Mehresh Ramneek-B31383 > <[email protected]>; [email protected] > Cc: [email protected]; [email protected]; linux- > [email protected] > Subject: RE: [PATCH 0/7][v4] Add OTG support for FSL socs > > Hi > > > -----Original Message----- > > From: [email protected] [mailto:linux-usb- > > [email protected]] On Behalf Of Felipe Balbi > > Sent: Wednesday, December 23, 2015 2:21 AM > > To: Ramneek Mehresh <[email protected]>; linux- > > [email protected] > > Cc: [email protected]; [email protected]; linux- > > [email protected] > > Subject: RE: [PATCH 0/7][v4] Add OTG support for FSL socs > > > > > > Hi, > > > > Ramneek Mehresh <[email protected]> writes: > > >> -----Original Message----- > > >> From: Felipe Balbi [mailto:[email protected]] > > >> Sent: Saturday, October 10, 2015 3:04 AM > > >> To: Mehresh Ramneek-B31383 <[email protected]>; > linux- > > >> [email protected] > > >> Cc: [email protected]; [email protected]; linux- > > >> [email protected]; Mehresh Ramneek-B31383 > > >> <[email protected]> > > >> Subject: Re: [PATCH 0/7][v4] Add OTG support for FSL socs > > >> > > >> Felipe Balbi <[email protected]> writes: > > >> > > >> > Hi, > > >> > > > >> > Ramneek Mehresh <[email protected]> writes: > > >> >> Add support for otg for all freescale socs having internal usb phy. > > >> >> > > >> >> Ramneek Mehresh (7): > > >> >> usb:fsl:otg: Make fsl otg driver as tristate > > >> >> usb:fsl:otg: Add controller version based ULPI and UTMI phy > > >> >> usb:fsl:otg: Add support to add/remove usb host driver > > >> >> usb:fsl:otg: Signal host drv when host is otg > > >> >> usb:fsl:otg: Modify otg_event to start host drv > > >> >> usb:fsl:otg: Combine host/gadget start/resume for ID change > > >> >> usb:fsl:otg: Add host-gadget drv sync delay > > >> > > > >> > Unless Alan's okay with the host side changes, I can't accept any > > >> > of these. However, I must say some of the flags you add here > > >> > already exist in some way, shape or form. For example, look at > > is_b_host flag. > > >> > > > > > > Could you please be more specific...which flag you think that I > > >should remove/I'm re-defining. The flags I'm defining are: > > > > > > have_hcd : defined in fsl specific structure for fsl specific > > > use-case > > > > > > had_hcd: defined in fsl specific structure for fsl specific use-case > > > > > > is_otg : defined in include/linux/usb.h > > > > > > Are you suggesting using otg_port or is_b_host instead of is_otg? > > > > > > As I understand, is_b_host is specifically to check if an otg B > > > device is in host mode...correct? I just need a flag to check if a > > > controller is capable of otg operations? That's why defined "is_otg" > > > flag. Please suggest. > > > > no, I don't know why I made that comment. You could use otg_port, but > > that wouldn't look very clean. Can you resend with Alan's ack, then > > I'll move this series into testing/next. > > > > -- > > balbi > > Can you directly put the change_hcd_work in its phy driver(phy-fsl-usb.c)? > Then add/remove hcd will not through ehci_fsl_drv_suspend/resume, With > this, you can make it work without a new flag "is_otg". > change_hcd_work() changes host controller mode, and hence, should be in host controller driver. To move this to phy driver (just to avoid usage of a single flag) won't be a good idea. In this case, I'll also have to move some host controller specific flags to phy drv which won't be correct.
> Li Jun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
