On Fri, Jan 01, 2016 at 02:07:41PM +0100, Arnd Bergmann wrote: > The newly added code for Fiji creates a correct compiler warning > about invalid use of the do_div macro: > > In file included from powerplay/hwmgr/ppatomctrl.c:31:0: > drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/ppevvmath.h: In function > 'fDivide': > drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/ppevvmath.h:382:89: warning: > comparison of distinct pointer types lacks a cast > do_div(longlongX, longlongY); /*Q(32,32) divided by Q(16,16) = Q(16,16) > Back to original format */ > > do_div() divides an unsigned 64-bit number by an unsigned 32-bit number. > The code instead wants to divide two signed 64-bit numbers, which is done > using the div64_s64 function. > > Signed-off-by: Arnd Bergmann <[email protected]> > Fixes: 770911a3cfbb ("drm/amd/powerplay: add/update headers for Fiji SMU and > DPM") > --- > Found on ARM allmodconfig on yesterday's linux-next
Reviewed-by: Thierry Reding <[email protected]>
signature.asc
Description: PGP signature
