On Mon, 18 Dec 2006, Linus Torvalds wrote:
>
> But at the same time, it's interesting that it still happens when we try
> to re-add the dirty bit. That would tell me that it's one of two cases:
Forget that. There's a third case, which is much more likely:
- Andrew's patch had a ", 1" where it _should_ have had a ", 0".
This should be fairly easy to test: just change every single ", 1" case in
the patch to ", 0".
The only case that _definitely_ would want ",1" is actually the case that
already calls page_mkclean() directly: clear_page_dirty_for_io(). So no
other ", 1" is valid, and that one that needed it already avoided even
calling the "test_clear_page_dirty()" function, because it did it all by
hand.
What happens for you in that case?
Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
