On Wed, 30 Dec 2015 23:06:41 +0000 Colin King <[email protected]> wrote:
> From: Colin Ian King <[email protected]> > > Fix build warning: > > scripts/recordmcount.c:589:4: warning: format not a string > literal and no format arguments [-Wformat-security] > sprintf("%s: failed\n", file); > > Fixes: a50bd43935586 ("ftrace/scripts: Have recordmcount copy the object > file") > Signed-off-by: Colin Ian King <[email protected]> > --- > scripts/recordmcount.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/recordmcount.c b/scripts/recordmcount.c > index 301d70b..e1675927 100644 > --- a/scripts/recordmcount.c > +++ b/scripts/recordmcount.c > @@ -586,7 +586,7 @@ main(int argc, char *argv[]) > do_file(file); > break; > case SJ_FAIL: /* error in do_file or below */ > - sprintf("%s: failed\n", file); > + fprintf(stderr, "%s: failed\n", file); Paper bag bug. I'm not sure how this passed my tests? My tests check for warnings. And I even got a "BUILD SUCCESS" from Fengguang Wu's kbuild test robot. I'll apply it, test it, and push it out soon. Thanks! -- Steve > ++n_error; > break; > case SJ_SUCCEED: /* premature success */ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
