On Tue, Jan 05, 2016 at 12:03:44PM +0900, Namhyung Kim wrote:
SNIP
> static int add_dynamic_entry(struct perf_evlist *evlist, const char *tok)
> {
> char *str, *event_name, *field_name, *opt_name;
> @@ -1995,7 +2017,12 @@ static int add_dynamic_entry(struct perf_evlist
> *evlist, const char *tok)
> }
>
> if (!strcmp(field_name, "trace_fields")) {
> - ret = add_all_dynamic_fields(evlist ,raw_trace);
> + ret = add_all_dynamic_fields(evlist, raw_trace);
> + goto out;
> + }
> +
> + if (event_name == NULL) {
> + ret = add_all_matching_fields(evlist, field_name, raw_trace);
> goto out;
should this be handled within find_evsel function:
/* case 1 */
if (event_name == NULL) {
if (evlist->nr_entries != 1) {
looks like it'd be dead code otherwise
thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
