It is unnecessary and invalid to call sysfs_remove_group()
after sysfs_create_group() failure.

Cc: Sebastien Bouchard <[EMAIL PROTECTED]>
Cc: Mark Gross <[EMAIL PROTECTED]>
Signed-off-by: Akinobu Mita <[EMAIL PROTECTED]>

---
 drivers/char/tlclk.c |    2 --
 1 file changed, 2 deletions(-)

Index: 2.6-mm/drivers/char/tlclk.c
===================================================================
--- 2.6-mm.orig/drivers/char/tlclk.c
+++ 2.6-mm/drivers/char/tlclk.c
@@ -807,8 +807,6 @@ static int __init tlclk_init(void)
                        &tlclk_attribute_group);
        if (ret) {
                printk(KERN_ERR "tlclk: failed to create sysfs device 
attributes.\n");
-               sysfs_remove_group(&tlclk_device->dev.kobj,
-                       &tlclk_attribute_group);
                goto out5;
        }
 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to