On Tue, 19 Dec 2006, Jan Engelhardt wrote: > > Get rid of the remaining obvious pointer casts of all k[cmz]alloc > >calls, and do a little whitespace cleanup on the result, based on the > >CodingStyle file. > > >- struct intmem_allocation* alloc = > >- (struct intmem_allocation*)kmalloc(sizeof *alloc, GFP_KERNEL); > >+ struct intmem_allocation* alloc = > >+ kmalloc(sizeof(*alloc), GFP_KERNEL); > > At the same time, you could make * alloc -> *alloc when it falls on > the same line as the kmczalloc cleanup. :)
i'd actually thought of that but, as with previous patches of mine, it's a trade-off -- the more i try to do at once, the more chance there is of having the patch rejected for some sort of incompatibility. as you may have noticed, i try to write scripts to automate a lot of this. this last patch definitely needed more manual work than previous patches so i was loathe to try to push the envelope -- i wanted to concentrate on the superfluous casts this time, and leave other issues for future, well-defined patches. "bit by bit," that's my motto. well, that and "life is too short to drink bad wine." rday - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/