Hi Alexandre, sorry, missed your comment. Please keep me on CC since I'm not subscribed to the list.
> > When setting a new time/date the RTC's clock must be stopped first, in > > order to write the time/date registers in an atomic manner. > > So, this change stops the clock first and then writes the time/date > > registers and the clock control register (to re-enable the clock) in one > > turn. > > I'd have the same comment for that patch. Using > i2c_smbus_write_byte_data and i2c_smbus_write_block_data would make the > code clearer and also more robust because it takes care of > retransmissions for example. Okay. Will have a look. Regards, Juergen -- Pengutronix e.K. | Juergen Borleis | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
