On Thu, Jan 07, 2016 at 09:07:17AM +0100, Jiri Olsa wrote:
> On Thu, Jan 07, 2016 at 04:46:22PM +0900, Namhyung Kim wrote:
>
> SNIP
>
> >
> > struct callchain_param callchain_param = {
> > .mode = CHAIN_GRAPH_ABS,
> > @@ -663,3 +665,28 @@ fetch_kernel_version(unsigned int *puint, char *str,
> > *puint = (version << 16) + (patchlevel << 8) + sublevel;
> > return 0;
> > }
> > +
> > +const char *perf_report_tip(const char *dirname)
> > +{
> > + struct strlist *tips;
> > + struct str_node *node;
> > + char *tip = NULL;
> > + struct strlist_config conf = {
> > + .dirname = system_path(dirname) ,
> > + };
> > +
> > + tips = strlist__new("tips.txt", &conf);
> > + if (tips == NULL || strlist__nr_entries(tips) == 1) {
> > + tip = (char *)"Cannot find tips.txt file";
> > + goto out;
>
> could we also try to read "./Documentation/tips.txt" ?
>
> so people who don't install perf and run it from 'tools/perf'
> get some tips as well? ;-)
I thought about that too. But using relative path is not a good idea
IMHO since there's no guarantee we're in the perf source directory.
Maybe we can path $srcdir or so, but given that only *very* few people
like you will need it, I'd rather not doing that. :)
Thanks,
Namhyung
>
> [jolsa@krava perf]$ ./perf report --stdio | tail -3
> #
> # (Cannot find tips.txt file)
> #
> [jolsa@krava perf]$
>
> thanks,
> jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
