Re: [PATCH V10 1/4] perf/powerpc: assign an id to each powerpc register

[Anju T]

On Wednesday 20 January 2016 04:08 PM, Michael Ellerman wrote:

Hi Anju,

On Mon, 2016-01-11 at 15:58 +0530, Anju T wrote:

The enum definition assigns an 'id' to each register in "struct pt_regs"
of arch/powerpc. The order of these values in the enum definition are
based on the corresponding macros in arch/powerpc/include/uapi/asm/ptrace.h.

Sorry one thing ...

diff --git a/arch/powerpc/include/uapi/asm/perf_regs.h 
b/arch/powerpc/include/uapi/asm/perf_regs.h
new file mode 100644
index 0000000..cfbd068
--- /dev/null
+++ b/arch/powerpc/include/uapi/asm/perf_regs.h
@@ -0,0 +1,49 @@
+#ifndef _ASM_POWERPC_PERF_REGS_H
+#define _ASM_POWERPC_PERF_REGS_H
+
+enum perf_event_powerpc_regs {
+       PERF_REG_POWERPC_GPR0,
+       PERF_REG_POWERPC_GPR1,
+       PERF_REG_POWERPC_GPR2,
+       PERF_REG_POWERPC_GPR3,
+       PERF_REG_POWERPC_GPR4,
+       PERF_REG_POWERPC_GPR5,
+       PERF_REG_POWERPC_GPR6,
+       PERF_REG_POWERPC_GPR7,
+       PERF_REG_POWERPC_GPR8,
+       PERF_REG_POWERPC_GPR9,
+       PERF_REG_POWERPC_GPR10,
+       PERF_REG_POWERPC_GPR11,
+       PERF_REG_POWERPC_GPR12,
+       PERF_REG_POWERPC_GPR13,
+       PERF_REG_POWERPC_GPR14,
+       PERF_REG_POWERPC_GPR15,
+       PERF_REG_POWERPC_GPR16,
+       PERF_REG_POWERPC_GPR17,
+       PERF_REG_POWERPC_GPR18,
+       PERF_REG_POWERPC_GPR19,
+       PERF_REG_POWERPC_GPR20,
+       PERF_REG_POWERPC_GPR21,
+       PERF_REG_POWERPC_GPR22,
+       PERF_REG_POWERPC_GPR23,
+       PERF_REG_POWERPC_GPR24,
+       PERF_REG_POWERPC_GPR25,
+       PERF_REG_POWERPC_GPR26,
+       PERF_REG_POWERPC_GPR27,
+       PERF_REG_POWERPC_GPR28,
+       PERF_REG_POWERPC_GPR29,
+       PERF_REG_POWERPC_GPR30,
+       PERF_REG_POWERPC_GPR31,
+       PERF_REG_POWERPC_NIP,
+       PERF_REG_POWERPC_MSR,
+       PERF_REG_POWERPC_ORIG_R3,
+       PERF_REG_POWERPC_CTR,
+       PERF_REG_POWERPC_LNK,
+       PERF_REG_POWERPC_XER,
+       PERF_REG_POWERPC_CCR,

You skipped SOFTE here at my suggestion, because it's called MQ on 32-bit.

But I've changed my mind, I think we *should* define SOFTE, and ignore MQ,
because MQ is unused. So just add:

   +    PERF_REG_POWERPC_SOFTE,

Thank you for reviewing the patch.

Yes here we can add SOFTE.


Thanks

Anju

+       PERF_REG_POWERPC_TRAP,
+       PERF_REG_POWERPC_DAR,
+       PERF_REG_POWERPC_DSISR,
+       PERF_REG_POWERPC_MAX,
+};
+#endif /* _ASM_POWERPC_PERF_REGS_H */

cheers