On Tue, Jan 19, 2016 at 06:26:44PM -0800, Andi Kleen wrote: > From: Andi Kleen <a...@linux.intel.com> > > Abstract the printing of shadow metrics. Instead of every > metric calling fprintf directly and taking care of indentation, > use two call backs: one to print metrics and another to > start a new line. > > This will allow adding metrics to CSV mode and also > using them for other purposes. > > The computation of padding is now done in the central > callback, instead of every metric doing it manually. > This makes it easier to add new metrics. > > v2: Refactor functions, printout now does more. Move > shadow printing. Improve fallback callbacks. Don't > use void * callback data. > v3: Remove unnecessary hunk. Add typedef for new_line > v4: Remove unnecessary hunk. Don't print metrics for CSV/interval > mode yet. Move printout change to separate patch. > v5: Fix bisect bugs. Avoid bogus frontend cycles printing. > Fix indentation in different aggregation modes. > v6: Delay newline handling > Signed-off-by: Andi Kleen <a...@linux.intel.com>
Acked-by: Jiri Olsa <jo...@kernel.org> thanks, jirka