On Thu, Jan 21, 2016 at 08:51:33PM -0300, Arnaldo Carvalho de Melo wrote: > Em Thu, Jan 21, 2016 at 01:07:10PM +0900, Namhyung Kim escreveu: > > On Wed, Jan 20, 2016 at 09:52:45PM -0300, Arnaldo Carvalho de Melo wrote: > > > Em Sun, Jan 17, 2016 at 01:03:08AM +0900, Namhyung Kim escreveu: > > > > When symbol sort key is not given, it doesn't show any item other than > > > > exit. Check sort key to select possible items. Also check items more > > > > strictly using sort key information. > > > > So, without this patch when I press enter on 'perf top' I can zoom into > > > threads, with it I lose that option. > > > Yes, but it was incorrect information. The default sort key of 'perf > > top' doesn't contain 'comm' (or 'pid') so hist entries it shows can > > have samples from different threads. The result is that it only shows > > thread of the first sample of the entry. Filtering based on this > > incorrect info should be avoided IMHO. > > Ok, agreed, but this patch is doing way too many things at once, please > take a look at my current perf/core branch, it has the first few patches > I carved out from this one, see if you are ok with it, will continue.
Look good to me! > > And this is not hierarchy related, so will go first, as fixes in > perf/core. Thanks, Namhyung
