Am 18.01.2016 um 18:07 schrieb Martin Kepplinger: > Am 2016-01-16 um 17:14 schrieb Alexander Koch: >> Enable operation of the TI OPT3001 light sensor without having an >> interrupt line available to connect the INT pin to. >> >> In this operation mode, we issue a conversion request and simply wait >> for the conversion time available as timeout value, determined from >> integration time configuration and the worst-case time given in the data >> sheet (sect. 6.5, table on p. 5): >> >> short integration time (100ms): 110ms + 3ms = 113ms >> long integration time (800ms): 880ms + 3ms = 883ms >> >> This change is transparent as behaviour defaults to using the interrupt >> method if an interrupt no. is configured via device tree. Interrupt-less >> operation mode is performed when no valid interrupt no. is given. >> >> Signed-off-by: Alexander Koch <[email protected]> >> Signed-off-by: Michael Hornung <[email protected]> >> --- >> drivers/iio/light/opt3001.c | 137 >> ++++++++++++++++++++++++++++++-------------- >> 1 file changed, 95 insertions(+), 42 deletions(-) >> > > Looks ok to me, although I didn't verify anything. Not very important > suggestions for changes inline
Thanks! Suggestions noted but if nobody objects I'd stick with v2 as I'm hoping to have it accepted in the merge window for 4.5. Regards Alex
