Hi John:
Welcome.
One nit.
On 2016年01月27日 08:37, John Stultz wrote:
Add device tree binding document for reboot-mode driver
Maybe you want to use "sram-reboot-mode" instead of "reboot-mode" here.
Cc: Andy Yan <andy....@rock-chips.com>
Cc: Rob Herring <r...@kernel.org>
Cc: Arnd Bergmann <a...@arndb.de>
Cc: Thierry Reding <tred...@nvidia.com>
Cc: Heiko Stübner <he...@sntech.de>
Cc: Caesar Wang <w...@rock-chips.com>
Cc: Kees Cook <keesc...@chromium.org>
Cc: Guodong Xu <guodong...@linaro.org>
Cc: Haojian Zhuang <haojian.zhu...@linaro.org>
Cc: Vishal Bhoj <vishal.b...@linaro.org>
Cc: Bjorn Andersson <bjorn.anders...@linaro.org>
Cc: devicet...@vger.kernel.org
Cc: Android Kernel Team <kernel-t...@android.com>
Signed-off-by: John Stultz <john.stu...@linaro.org>
---
.../bindings/power/reset/sram-reboot-mode.txt | 47 ++++++++++++++++++++++
1 file changed, 47 insertions(+)
create mode 100644
Documentation/devicetree/bindings/power/reset/sram-reboot-mode.txt
diff --git a/Documentation/devicetree/bindings/power/reset/sram-reboot-mode.txt
b/Documentation/devicetree/bindings/power/reset/sram-reboot-mode.txt
new file mode 100644
index 0000000..33bb132
--- /dev/null
+++ b/Documentation/devicetree/bindings/power/reset/sram-reboot-mode.txt
@@ -0,0 +1,47 @@
+SRAM reboot mode driver
+
+This driver get reboot mode magic value form reboot-mode driver
+and stores it in a SRAM address. Then the bootloader
+can read it and take different action according to the magic
+value stored.
+
+This DT node should be represented as a sub-node of a "mmio-sram", "simple-bus"
+node.
+
+Required properties:
+- compatible: should be "sram-reboot-mode"
+- reg: offset from the sram range where to store the magic value(in bytes)
+
+The rest of the properties should follow the generic reboot-mode discription
+found in reboot-mode.txt
+
+Example:
+
+ sram@5f01000 {
+ compatible = "mmio-sram", "simple-bus";
+ reg = <0x0 0x05f01000 0x0 0x00001000>;
+ ranges = <0x0 0x0 0x05f01000 0x00001000>;
+
+ #address-cells = <1>;
+ #size-cells = <1>;
+
+ reboot-mode@0 {
+ compatible = "sram-reboot-mode";
+ reg = <0x0 0x4>;
+
+ none {
+ linux,mode = "none";
+ loader,magic = <0x77665501>;
+ };
+
+ bootloader {
+ linux,mode = "bootloader";
+ loader,magic = <0x77665500>;
+ };
+
+ recovery {
+ linux,mode = "recovery";
+ loader,magic = <0x77665502>;
+ };
+ };
+ };
