Re: [RFC PATCH 14/21] mmc: sdhci-esdhc-imx: remove SDHCI_QUIRK_BROKEN_CARD_DETECTION

[Shawn Lin]

On 2016/1/27 14:54, Haibo Chen wrote:

Hi Shawn,

Comments below.

[...]

                return ret;

        if (!IS_ERR_VALUE(mmc_gpio_get_cd(host->mmc)))
-               host->quirks &= ~SDHCI_QUIRK_BROKEN_CARD_DETECTION;
+               host->mmc->caps &= MMC_CAP_NEEDS_POLL;

You miss ' ~', seems you need to change to:
host->mmc->caps &=~ MMC_CAP_NEEDS_POLL;

Thanks for pointing out. I will fix this for the next version.

        return 0;
  }
@@ -1064,7 +1063,7 @@ static int sdhci_esdhc_imx_probe_nondt(struct
platform_device *pdev,

        case ESDHC_CD_CONTROLLER:
                /* we have a working card_detect back */
-               host->quirks &= ~SDHCI_QUIRK_BROKEN_CARD_DETECTION;
+               host->mmc->caps &= MMC_CAP_NEEDS_POLL;

The same issue.

                break;

        case ESDHC_CD_PERMANENT:
@@ -1104,6 +1103,8 @@ static int sdhci_esdhc_imx_probe(struct
platform_device *pdev)
        if (IS_ERR(host))
                return PTR_ERR(host);

+       host->mmc->caps |= MMC_CAP_NEEDS_POLL;
+
        pltfm_host = sdhci_priv(host);

        imx_data = devm_kzalloc(&pdev->dev, sizeof(*imx_data),
GFP_KERNEL);
--
2.3.7

--
Best Regards
Shawn Lin