4.2.8-ckt3 -stable review patch.  If anyone has any objections, please let me 
know.

---8<------------------------------------------------------------

From: Dan Carpenter <dan.carpen...@oracle.com>

commit d16a2b9f2465b5486f830178fbfb7d203e0a17ae upstream.

"data" is always NULL in this function.  I think we should be passing
"&data" to sst_prepare_and_post_msg() instead of "data".

Fixes: 3d9ff34622ba ('ASoC: Intel: sst: add stream operations')
Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com>
Tested-by: Dinesh Mirche <dinesh.mir...@intel.com>
Acked-by: Vinod Koul <vinod.k...@intel.com>
Signed-off-by: Mark Brown <broo...@kernel.org>
Signed-off-by: Kamal Mostafa <ka...@canonical.com>
---
 sound/soc/intel/atom/sst/sst_stream.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/intel/atom/sst/sst_stream.c 
b/sound/soc/intel/atom/sst/sst_stream.c
index a74c64c..4ccc80e 100644
--- a/sound/soc/intel/atom/sst/sst_stream.c
+++ b/sound/soc/intel/atom/sst/sst_stream.c
@@ -108,7 +108,7 @@ int sst_alloc_stream_mrfld(struct intel_sst_drv 
*sst_drv_ctx, void *params)
                        str_id, pipe_id);
        ret = sst_prepare_and_post_msg(sst_drv_ctx, task_id, IPC_CMD,
                        IPC_IA_ALLOC_STREAM_MRFLD, pipe_id, sizeof(alloc_param),
-                       &alloc_param, data, true, true, false, true);
+                       &alloc_param, &data, true, true, false, true);
 
        if (ret < 0) {
                dev_err(sst_drv_ctx->dev, "FW alloc failed ret %d\n", ret);
-- 
1.9.1

Reply via email to