Re: [PATCH] irqchip: mxs: add missing set_handle_irq()

[Oleksij Rempel]

Am 29.01.2016 um 09:33 schrieb Thomas Gleixner:
> On Fri, 29 Jan 2016, Oleksij Rempel wrote:
> 
>> this will fix IRQ related issues on Alphascale ASM9260
> 
> This really does not qualify as a changelog.
> 
> 1) What's the problem and what consequences does it have
> 
> 2) What's the fix.
> 
> Thanks,
> 
>       tglx
> 

The driver provide this function:
asmlinkage void __exception_irq_entry icoll_handle_irq(struct pt_regs *regs)
{
        u32 irqnr;

        irqnr = __raw_readl(icoll_priv.stat);
        __raw_writel(irqnr, icoll_priv.vector);
        handle_domain_irq(icoll_domain, irqnr, regs);
}

i assume at some late review point instead of move it to asm9260_of_init
i removed it completely. As result, the driver was compilable but not
working.

Should i put this explanation to changelog?
-- 
Regards,
Oleksij

signature.asc
Description: OpenPGP digital signature