> -----Original Message----- > From: Matt Fleming [mailto:[email protected]] > Sent: Wednesday, February 3, 2016 5:28 AM > To: Ingo Molnar <[email protected]> > Cc: Laszlo Ersek <[email protected]>; H . Peter Anvin <[email protected]>; > Thomas Gleixner <[email protected]>; [email protected]; linux- > [email protected]; Elliott, Robert (Persistent Memory) > <[email protected]>; Andy Shevchenko <[email protected]>; > Ard Biesheuvel <[email protected]>; Taku Izumi > <[email protected]>; Linus Torvalds <torvalds@linux- > foundation.org>; Andrew Morton <[email protected]> > Subject: Re: [PATCH 14/14] x86/efi: Print size in binary units in > efi_print_memmap ... > OK, this patch has caused enough headaches. Let's drop it from this > series. > > Robert, Andy, feel free to resubmit it after you've addressed > everyone's concerns and we can discuss it in isolation.
We could just delete the size print altogether - better to print nothing than a silently rounded number. The end address already communicates the size - it's just not as readable. The e820 table prints don't bother with a size print. That would also shorten these extremely wide prints to 116 characters (131 if printk time is enabled). [ 0.000000] BIOS-e820: [mem 0x0000001880000000-0x000000207fffffff] reserved vs. [ 0.000000] efi: mem62: [Reserved | | |NV| | | | | |WB|WT|WC|UC] range=[0x0000001880000000-0x000000207fffffff] (32 GiB) --- Robert Elliott, HPE Persistent Memory
