On Wed, Dec 27, 2006 at 04:42:23PM +0300, Alexey Dobriyan wrote:
> 
>       struct proc_entry_raw foo_pe_raw = {
>               .owner = THIS_MODULE,
>               .name = "foo",
>               .mode = 0644,
>               .read_proc = foo_read_proc,
>               .data = foo_data,
>               .parent = foo_parent,
>       };
> 
>       pde = create_proc_entry(&foo_pe_raw);
>       if (!pde)
>               return -ENOMEM;
> 
>    where "struct proc_entry_raw" is cut down version of "struct 
> proc_dir_entry"

Ewwwwwwwwwwwwwww

Please, please no.  Especially not .parent.  If anything, let's add a
helper saying "it's all set up now".  And turn create_proc_entry()
into a macro that would pass THIS_MODULE to underlying function and
call that helper, so that simple cases wouldn't have to bother at all.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to