>From: Daniel Lezcano [mailto:[email protected]]
>Sent: Wednesday, February 10, 2016 12:55 AM
>> pr_err() in case of error just like most drivers around. By "hang" do
>> you mean calling panic()?
>No. I meant the errors are caught but no action is taken, the execution
>continues normally as nothing wrong happened. This is why I asked if you
>expect the host to hang at boot time with the last error as a hint.
>I was expecting to see a call to clk_disable_unprepare if
>clocksource_register_hz fails, and returning 'ret' if clk_prepare_enable fails.
Ok, I will fix that, and handle gracefull return. Thanks
>Using the mmio generic code will save:
>+static struct clocksource nps_counter = {
>+ .name = "EZnps-tick",
>+ .rating = 301,
>+ .read = nps_clksrc_read,
>+ .mask = CLOCKSOURCE_MASK(32),
>+ .flags = CLOCK_SOURCE_IS_CONTINUOUS,
>+};
>Up to you.
I will do that, thanks again
Noam
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
