On Thu, 11 Feb 2016, Ralf Baechle wrote: > > Signed-off-by: Daniel Wagner <daniel.wag...@bmw-carit.de> > > Suggested-by: Maciej W. Rozycki <ma...@imgtec.com> > > Reviewed-by: Maciej W. Rozycki <ma...@imgtec.com> > > Reported-by: Fengguang Wu <fengguang...@intel.com> > > Thanks, applied. > > I'm getting a less spectacular warning from gcc 5.2: > > CC fs/proc/vmcore.o > fs/proc/vmcore.c: In function ‘parse_crash_elf64_headers’: > fs/proc/vmcore.c:939:47: warning: initialization from incompatible pointer > type [-Wincompatible-pointer-types]
Yes, the temporaries still need to have their pointed types changed, to `Elf32_Ehdr' and `Elf64_Ehdr' respectively, as in the original change. I had it mentioned in a WIP version of my review (stating that it would verify that the correct type is used by the caller), but then deleted that part inadvertently, sigh. Daniel, sorry for the extra iteration. Maciej
