Re: [lkp] [printk] af097cab1b: EIP is at vprintk_emit+0xab2/0xb5c

[Sergey Senozhatsky]

On (02/15/16 09:43), kernel test robot wrote:
> FYI, we noticed the below changes on
> 
> https://github.com/0day-ci/linux 
> Sergey-Senozhatsky/printk-move-can_use_console-out-of-console_trylock_for_printk/20160213-024210
> commit af097cab1b878d5be746be8bcaa9a79986716c41 ("printk: set may_schedule 
> for some of console_trylock callers")


Hello,
thanks for reporting,

any chance you can test the patch below?

---

 kernel/printk/printk.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
index 9917f69..7268a40 100644
--- a/kernel/printk/printk.c
+++ b/kernel/printk/printk.c
@@ -2208,7 +2208,7 @@ void console_unlock(void)
        static u64 seen_seq;
        unsigned long flags;
        bool wake_klogd = false;
-       bool do_cond_resched, retry;
+       bool do_cond_resched, retry = false;
 
        if (console_suspended) {
                up_console_sem();
@@ -2241,7 +2241,8 @@ again:
        }
 
        /* flush buffered message fragment immediately to console */
-       console_cont_flush(text, sizeof(text));
+       if (!retry)
+               console_cont_flush(text, sizeof(text));
 
        for (;;) {
                struct printk_log *msg;