On 2016-02-14 Baoquan He wrote:
> On 02/13/16 at 08:57pm, Lasse Collin wrote:
> > The long comment in arch/x86/boot/compressed/misc.c explains the
> > need for the offset for gzip/Deflate. A similar comment in
> > lib/decompress_unxz.c explains it for XZ/LZMA2.
>
> Thank you so much, Lasse. You clearly pointed out my confusion.
> Yeah, I didn't understand it well. Your description for xz in
> lib/decompress_unxz.c is very helpful. The 64K is the maximum payload
> in one chunk. Adding this 64K is to avoid the worst case that very
> small payload can reprsent a 64K uncompressed output data. With my
> understanding it could be a chunk which contains complete duplicate
> content. like all "0" or other stuff?
Yes, like all zeros. I wrote another explanation just in case it helps:
In-place decompression puts the compressed data at the end of the
buffer and decompresses it to the beginning of the buffer:
F = free memory
K = uncompressed kernel
C = compressed input data
Start: FFFFFFFFFFFFFFCCCCCCCC
Decompressing: KKKKKKKKKKFFFFFFFFCCCC
Finished: KKKKKKKKKKKKKKKKKKKKFF
The free memory (FF) at the end is the safety margin.
In the worst case the beginning of the uncompressed data compresses to
almost nothing (like all zeros do), and the end of the data is
incompressible. In the beginning the write position of the decompressor
advances quickly while the read position moves very little, and thus
the write position quickly approaches the read position:
Start: FFFFFFFFFFFFFFCCCCCCCC
Decompressing: KKKKKKKKKKKKKKFCCCCCCC
Finished: KKKKKKKKKKKKKKKKKKKKFF
The safety margin ensures that the write position can never overtake
the read position.
--
Lasse Collin | IRC: Larhzu @ IRCnet & Freenode
