On Tue, Feb 16, 2016 at 01:56:45PM +0100, Andreas Irestål wrote: > Currently, it is only possible to configure HW-specific options to the > adau17x1 codecs by providing a platform data struct. With this patch, > it is possible to provide the same data via DT instead.
The subject is a red flag. Platform data and DT properties are not necessarily equivalent. This should be part of the previous patch. > > Signed-off-by: Andreas Irestål <[email protected]> > --- > .../devicetree/bindings/sound/adi,adau17x1.txt | 31 +++++ > include/dt-bindings/sound/adau17x1.h | 14 +++ > sound/soc/codecs/adau1761.c | 127 > +++++++++++++++++++++ > sound/soc/codecs/adau1781.c | 48 ++++++++ > 4 files changed, 220 insertions(+) > create mode 100644 include/dt-bindings/sound/adau17x1.h > > diff --git a/Documentation/devicetree/bindings/sound/adi,adau17x1.txt > b/Documentation/devicetree/bindings/sound/adi,adau17x1.txt > index 8dbce0e..6050602 100644 > --- a/Documentation/devicetree/bindings/sound/adi,adau17x1.txt > +++ b/Documentation/devicetree/bindings/sound/adi,adau17x1.txt > @@ -13,6 +13,32 @@ Required properties: > - reg: The i2c address. Value depends on the state of > ADDR0 > and ADDR1, as wired in hardware. > > +Optional properties: > + > + - adi,input-differential bool to set if the input is differential > + - adi,digital-microphone bool to set if there is a digital microphone > + connected to digmic/jackdet pin. > + - adi,micbias-vg Microphone bias voltage In what units? Add units suffix. Also, this seems like something that should be common. > + MICBIAS_0_90_AVDD - 0.9 * AVDD > + MICBIAS_0_65_AVDD - 0.65 * AVDD What does this mean? > + > +Optional properties (ADAU1361/ADAU1461/ADAU1761/ADAU1961 only) > + > + - adi,jack-detection If present, configures codec to use the > digmic/jackdet > + pin for jack detection. must provide one of > + JACKDETECT_ACTIVE_LO or JACKDETECT_ACTIVE_HI followed > + by debounce time in ms, which must be 5, 10, 20, or 40. Seems like this could be common. No existing examples to copy? > + > + - adi,lineout-mode Set output mode of the lineout pins. > + - adi,headphone-mode Set output mode of the headphone pins. > + > +The output mode must be one of: > + OUTPUT_MODE_HEADPHONE - Headphone output > + OUTPUT_MODE_HEADPHONE_CAPLESS - Capless headphone output > + OUTPUT_MODE_LINE - Line output
