On 19/02/16 13:08, Luis R. Rodriguez wrote: > The current check is a super long winded way of asking if this > is on lguest. The flags is used for legacy features, this is > likely inspired by the ACPI IA-PC boot architecture flags, where > as for RTC it annotates No CMOS real-time clock present. I don't > expect we will be implementing more legacy features, its simply > pointless so just remove this legacy flag feature thing as well.
No. This check is needed for Xen PV domU guests and without it PV guests don't get a console (as I think the history of the change that introduced this makes clear). I think this trend towards a coarse-grained subarch instead of a set of feature bits is the wrong direction. David