On Fri, Feb 19, 2016 at 10:14:42AM -0500, Boris Ostrovsky wrote: > > > On 02/19/2016 09:15 AM, Luis R. Rodriguez wrote: > >diff --git a/arch/x86/boot/bitops.h b/arch/x86/boot/bitops.h > >index 878e4b9940d9..232cff0ff4e3 100644 > >--- a/arch/x86/boot/bitops.h > >+++ b/arch/x86/boot/bitops.h > >@@ -40,4 +40,6 @@ static inline void set_bit(int nr, void *addr) > > asm("btsl %1,%0" : "+m" (*(u32 *)addr) : "Ir" (nr)); > > } > >+#define BIT(x) (1 << x) > > Parenthesize x.
I'll just use (1UL << (nr)) then as well to match what include/linux/bitmap.h uses. Luis