On Wed, Feb 17, 2016 at 02:44:02PM -0800, Andi Kleen wrote:
SNIP
> +static void aggr_update_shadow(void)
> +{
> + int cpu, cpu2, s2, id, s;
> + u64 val;
> + struct perf_evsel *counter;
> +
> + for (s = 0; s < aggr_map->nr; s++) {
> + id = aggr_map->map[s];
> + evlist__for_each(evsel_list, counter) {
> + val = 0;
> + for (cpu = 0; cpu < perf_evsel__nr_cpus(counter);
> cpu++) {
> + cpu2 = perf_evsel__cpus(counter)->map[cpu];
> + s2 = aggr_get_id(evsel_list->cpus, cpu2);
> + if (s2 != id)
> + continue;
> + val += perf_counts(counter->counts, cpu,
> 0)->val;
> + }
> + val = val * counter->scale;
> + perf_stat__update_shadow_stats(counter, &val,
> +
> first_shadow_cpu(counter, id));
> + }
> + }
> +}
> +
> static void print_aggr(char *prefix)
> {
> FILE *output = stat_config.output;
> @@ -982,6 +1024,8 @@ static void print_aggr(char *prefix)
> if (!(aggr_map || aggr_get_id))
> return;
>
> + aggr_update_shadow();
this should be called from perf_stat_process_counter,
not from display function
also please document somewhere (best around shadow stats variables)
what cpus (array members) are used for given AGGR_*
thanks,
jirka
