On Sun, Feb 21, 2016 at 11:22:34PM +0900, Namhyung Kim wrote:
> The dynamic entry is created for each field in a tracepoint event.
> Since they have no fixed hpp format index, it should skip when
> perf_hpp__reset_width() is called.
>
> This caused following assertion failure..
>
> $ perf record -e sched:sched_switch -a sleep 1
>
> $ perf report -s comm,next_pid --stdio
> perf: ui/hist.c:651: perf_hpp__reset_width:
> Assertion `!(fmt->idx >= PERF_HPP__MAX_INDEX)' failed.
>
> Signed-off-by: Namhyung Kim <namhy...@kernel.org>
Acked-by: Jiri Olsa <jo...@kernel.org>
thanks,
jirka
> ---
> tools/perf/ui/hist.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tools/perf/ui/hist.c b/tools/perf/ui/hist.c
> index 1ba4117d9c2d..12223d791e9f 100644
> --- a/tools/perf/ui/hist.c
> +++ b/tools/perf/ui/hist.c
> @@ -645,6 +645,9 @@ void perf_hpp__reset_width(struct perf_hpp_fmt *fmt,
> struct hists *hists)
> if (perf_hpp__is_sort_entry(fmt))
> return perf_hpp__reset_sort_width(fmt, hists);
>
> + if (perf_hpp__is_dynamic_entry(fmt))
> + return;
> +
> BUG_ON(fmt->idx >= PERF_HPP__MAX_INDEX);
>
> switch (fmt->idx) {
> --
> 2.7.1
>
