From: Andrzej Hajda <[email protected]>

cpumask_any_but returns value >= nr_cpu_ids if there are no more CPUs.

The problem has been detected using proposed semantic patch
scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1].

[1]: http://permalink.gmane.org/gmane.linux.kernel/2038576

Signed-off-by: Andrzej Hajda <[email protected]>
Acked-by: Will Deacon <[email protected]>
Signed-off-by: Suzuki K Poulose <[email protected]>
---
 drivers/bus/arm-cci.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/bus/arm-cci.c b/drivers/bus/arm-cci.c
index ee47e6b..5fb1c06 100644
--- a/drivers/bus/arm-cci.c
+++ b/drivers/bus/arm-cci.c
@@ -1270,7 +1270,7 @@ static int cci_pmu_cpu_notifier(struct notifier_block 
*self,
                if (!cpumask_test_and_clear_cpu(cpu, &cci_pmu->cpus))
                        break;
                target = cpumask_any_but(cpu_online_mask, cpu);
-               if (target < 0) // UP, last CPU
+               if (target >= nr_cpu_ids) // UP, last CPU
                        break;
                /*
                 * TODO: migrate context once core races on event->ctx have
-- 
1.7.9.5

Reply via email to